Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] DropDown 테스트 코드 작성 & 접근성 aria 속성 추가 #166

Merged
merged 4 commits into from
Oct 21, 2024
Merged

[Feature] DropDown 테스트 코드 작성 & 접근성 aria 속성 추가 #166

merged 4 commits into from
Oct 21, 2024

Conversation

SeieunYoo
Copy link
Collaborator

🎉 변경 사항

  • 드롭다운 테스트 코드 작성하며 aria 속성도 추가합니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@SeieunYoo SeieunYoo changed the title feat: DropDown 테스트 코드 작성 & 접근성 aria 속성 추가 [Feature] DropDown 테스트 코드 작성 & 접근성 aria 속성 추가 Sep 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-dthgadyqam.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-aotpddjzro.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ktbpjjtuyh.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

eugene028
eugene028 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당

@SeieunYoo SeieunYoo merged commit a3ab726 into main Oct 21, 2024
3 checks passed
@SeieunYoo SeieunYoo deleted the feature/dropdown-test-code branch October 21, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 eugene028 approved these changes

@hamo-o hamo-o Awaiting requested review from hamo-o hamo-o is a code owner

Assignees

@SeieunYoo SeieunYoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] DropDown 테스트 코드
3 participants
@SeieunYoo @eugene028 @ghdtjgus76